From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v5 08/12] xhci: Add Intel extended cap / otg phy mux handling Date: Wed, 28 Feb 2018 16:42:32 +0100 Message-ID: <070f5ccd-dfeb-1e47-681a-8e116472ef9f@redhat.com> References: <20180228150749.26831-1-hdegoede@redhat.com> <20180228150749.26831-9-hdegoede@redhat.com> <20180228151552.GA5335@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180228151552.GA5335@kuha.fi.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Greg Kroah-Hartman , Guenter Roeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org Hi, On 28-02-18 16:15, Heikki Krogerus wrote: > On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index 96099a245c69..5917e3095e2a 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1825,6 +1825,7 @@ struct xhci_hcd { >> /* Reserved. It was XHCI_U2_DISABLE_WAKE */ >> #define XHCI_ASMEDIA_MODIFY_FLOWCONTROL (1 << 28) >> #define XHCI_HW_LPM_DISABLE (1 << 29) >> +#define XHCI_INTEL_USB_ROLE_SW (1 << 30) > > Did you rebased these on tope of the latest usb-next? No I did not expect that to be necessary, but I see now that it is. I've just done a rebase locally, any other remarks before I send out a v6? > This does not > apply cleanly on top of linux-next. Regards, Hans