From: Armin Wolf <W_Armin@gmx.de>
To: "Kurt Borja" <kuurtb@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Dell.Client.Kernel@dell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
Date: Sun, 16 Feb 2025 06:49:56 +0100 [thread overview]
Message-ID: <076a5b8c-e401-4bf0-80f6-130daae61c48@gmx.de> (raw)
In-Reply-To: <20250208051614.10644-5-kuurtb@gmail.com>
Am 08.02.25 um 06:16 schrieb Kurt Borja:
> Rename supported_thermal_profiles[] -> supported_profiles[] and change
> it's type to u8 because it stores AWCC thermal IDs.
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index 57897a0f4296..4a8335d90b5d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -212,7 +212,7 @@ struct wmax_u32_args {
> struct awcc_priv {
> struct wmi_device *wdev;
> struct device *ppdev;
> - enum awcc_thermal_profile supported_thermal_profiles[PLATFORM_PROFILE_LAST];
> + u8 supported_profiles[PLATFORM_PROFILE_LAST];
> };
>
> static const enum platform_profile_option awcc_mode_to_platform_profile[AWCC_PROFILE_LAST] = {
> @@ -606,7 +606,7 @@ static int awcc_platform_profile_set(struct device *dev,
> }
>
> return awcc_thermal_control(priv->wdev,
> - priv->supported_thermal_profiles[profile]);
> + priv->supported_profiles[profile]);
> }
>
> static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
> @@ -643,7 +643,7 @@ static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
>
> mode = FIELD_GET(AWCC_THERMAL_MODE_MASK, id);
> profile = awcc_mode_to_platform_profile[mode];
> - priv->supported_thermal_profiles[profile] = id;
> + priv->supported_profiles[profile] = id;
>
> set_bit(profile, choices);
> }
> @@ -652,7 +652,7 @@ static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
> return -ENODEV;
>
> if (awcc->gmode) {
> - priv->supported_thermal_profiles[PLATFORM_PROFILE_PERFORMANCE] =
> + priv->supported_profiles[PLATFORM_PROFILE_PERFORMANCE] =
> AWCC_THERMAL_MODE_GMODE;
>
> set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
next prev parent reply other threads:[~2025-02-16 5:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 5:16 [PATCH 00/10] HWMON support + DebugFS + Improvements Kurt Borja
2025-02-08 5:16 ` [PATCH 01/10] platform/x86: alienware-wmi-wmax: Rename thermal related symbols Kurt Borja
2025-02-16 5:40 ` Armin Wolf
2025-02-08 5:16 ` [PATCH 02/10] platform/x86: alienware-wmi-wmax: Refactor is_awcc_thermal_mode() Kurt Borja
2025-02-16 5:44 ` Armin Wolf
2025-02-08 5:16 ` [PATCH 03/10] platform/x86: alienware-wmi-wmax: Improve internal AWCC API Kurt Borja
2025-02-16 5:48 ` Armin Wolf
2025-02-08 5:16 ` [PATCH 04/10] platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[] Kurt Borja
2025-02-16 5:49 ` Armin Wolf [this message]
2025-02-08 5:16 ` [PATCH 05/10] platform/x86: alienware-wmi-wmax: Improve platform profile probe Kurt Borja
2025-02-16 5:57 ` Armin Wolf
2025-02-08 5:16 ` [PATCH 06/10] platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile Kurt Borja
2025-02-16 5:59 ` Armin Wolf
2025-02-08 5:16 ` [PATCH 07/10] platform/x86: alienware-wmi-wmax: Add HWMON support Kurt Borja
2025-02-16 6:06 ` Armin Wolf
2025-02-16 21:27 ` Kurt Borja
2025-02-08 5:16 ` [PATCH 08/10] platform/x86: alienware-wmi-wmax: Add support for manual fan control Kurt Borja
2025-02-16 6:12 ` Armin Wolf
2025-02-16 6:14 ` Armin Wolf
2025-02-16 21:25 ` Kurt Borja
2025-02-08 5:16 ` [PATCH 09/10] platform/x86: alienware-wmi-wmax: Add a DebugFS interface Kurt Borja
2025-02-08 5:16 ` [PATCH 10/10] platform/x86: alienware-wmi: Improve and update documentation Kurt Borja
2025-02-16 6:22 ` Armin Wolf
2025-02-16 20:51 ` Kurt Borja
2025-02-16 21:29 ` Armin Wolf
2025-02-16 21:38 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076a5b8c-e401-4bf0-80f6-130daae61c48@gmx.de \
--to=w_armin@gmx.de \
--cc=Dell.Client.Kernel@dell.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox