From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bhardwaj, Rajneesh" Subject: Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static Date: Fri, 5 Apr 2019 20:19:21 +0530 Message-ID: <0822b960-be6e-6fcd-fed5-1825d2818b80@linux.intel.com> References: <1553632152-18888-1-git-send-email-linux@roeck-us.net> <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Guenter Roeck , Rajneesh Bhardwaj , Vishwanath Somayaji , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List List-Id: platform-driver-x86.vger.kernel.org Sending again as i got delivery failure notification from the mailing list for some reason. On 05-Apr-19 8:15 PM, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh > wrote: >> >> On 27-Mar-19 1:59 AM, Guenter Roeck wrote: >>> 0day reports: >>> >>> drivers/platform/x86/intel_pmc_core.c:833:5: sparse: >>> symbol 'quirk_xtal_ignore' was not declared. Should it be static? >> Looks good to me. > Please, give a corresponding tag. > Meanwhile I will apply it to my review and testing queue for robots to > play with, thanks! Sure. Acked-by: Rajneesh Bhardwaj >>> Mark the function static since it is indeed only called locally. >>> >>> Cc: Rajneesh Bhardwaj >>> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown") >>> Signed-off-by: Guenter Roeck >>> --- >>> drivers/platform/x86/intel_pmc_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c >>> index f2c621b55f49..9908d233305e 100644 >>> --- a/drivers/platform/x86/intel_pmc_core.c >>> +++ b/drivers/platform/x86/intel_pmc_core.c >>> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = { >>> * the platform BIOS enforces 24Mhx Crystal to shutdown >>> * before PMC can assert SLP_S0#. >>> */ >>> -int quirk_xtal_ignore(const struct dmi_system_id *id) >>> +static int quirk_xtal_ignore(const struct dmi_system_id *id) >>> { >>> struct pmc_dev *pmcdev = &pmc; >>> u32 value; > >