Re: [PATCH] Lenovo IdeaPAD ACPI driver

[David Woodhouse <dwmw2@infradead.org>]

On Wed, 2010-08-11 at 15:51 +0200, Corentin Chary wrote:
> On Wed, Aug 11, 2010 at 3:39 PM, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Wed, 2010-08-11 at 14:59 +0200, Corentin Chary wrote:
> >> I'd suggest to name it ideapad-laptop (IDEAPAD_LAPTOP). We try to use
> >> that name for laptop related drivers.
> >
> > OK.
> >
> >> But ... new WMI drivers are named with the *-wmi suffix. So I'm not
> >> really sure. Anyway, it's not really important.
> >
> > It doesn't do any WMI stuff... yet. I was looking at your discussion
> > from April and hoping you'd help make it work...
> 
> I'd suggest you to read http://lwn.net/Articles/391230/  :)

Ah, thanks. I'd seen Matthew's article on basic ACPI drivers, but hadn't
seen this one.

> And you should probably make it a platform driver (being the parent of
> acpi, wmi, input, backlight, rfkill, etc..).

I had faked a platform device to start with, but got rid of it as soon
as I had the acpi_device to use instead.

> Is there a lot of thing hidden in ACPI / WMI on these models (like
> hotkeys, backlight, light sensors)  ?

I think so, yes. My primary focus was the rfkill, which was breaking
wireless connectivity unless we have a way to turn it off -- but now I'm
here I may as well see what else I can do with it.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation