From: Maximilian Luz <luzmaximilian@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Gross" <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/3] surface: surface3_power: Switch back to use struct i2c_driver's .probe()
Date: Mon, 12 Jun 2023 12:53:46 +0200 [thread overview]
Message-ID: <12b4bfb2-54a6-74b5-ee3c-3ddad6c57f37@gmail.com> (raw)
In-Reply-To: <20230612073902.840435-2-u.kleine-koenig@pengutronix.de>
On 6/12/23 09:39, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks!
Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/platform/surface/surface3_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/surface/surface3_power.c
> index 73961a24c849..4c0f92562a79 100644
> --- a/drivers/platform/surface/surface3_power.c
> +++ b/drivers/platform/surface/surface3_power.c
> @@ -573,7 +573,7 @@ static const struct acpi_device_id mshw0011_acpi_match[] = {
> MODULE_DEVICE_TABLE(acpi, mshw0011_acpi_match);
>
> static struct i2c_driver mshw0011_driver = {
> - .probe_new = mshw0011_probe,
> + .probe = mshw0011_probe,
> .remove = mshw0011_remove,
> .driver = {
> .name = "mshw0011",
next prev parent reply other threads:[~2023-06-12 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 7:38 [PATCH 0/3] platform: Switch back to use struct i2c_driver's .probe() Uwe Kleine-König
2023-06-12 7:39 ` [PATCH 1/3] surface: surface3_power: " Uwe Kleine-König
2023-06-12 10:53 ` Maximilian Luz [this message]
2023-06-12 7:39 ` [PATCH 2/3] platform/x86: asus-tf103c-dock: " Uwe Kleine-König
2023-06-12 7:39 ` [PATCH 3/3] platform/x86: int3472: " Uwe Kleine-König
2023-06-12 10:51 ` [PATCH 0/3] platform: " Maximilian Luz
2023-06-12 11:03 ` Hans de Goede
2023-06-13 10:33 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b4bfb2-54a6-74b5-ee3c-3ddad6c57f37@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kernel@pengutronix.de \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox