From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Corentin Chary <corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Richard,
Keng-Yu Lin <kengyu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] asus-wmi: explicitly set the wireless LED
Date: Thu, 15 Dec 2011 09:26:47 +0100 [thread overview]
Message-ID: <1323937607.3337.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAHR064ivFUeGwNAfB1MZO0mrvo+sAcM-cZTjR9wZTaPyWRhzAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (sfid-20111215_092552_215332_009CBEB1)
On Thu, 2011-12-15 at 09:25 +0100, Corentin Chary wrote:
> > static const char *rfkill_ledtrigname(struct rfkill *rfkill)
> > {
> > #ifdef CONFIG_RFKILL_LEDS
> > return rfkill->ledtrigname;
> > #endif
> > return NULL;
> > }
> Right, but is rfkill->ledtrigname really set somewhere ?
>
> rfkill->led_trigger.name seems safer to use.
Hm, indeed -- looks like we can get rid of ledtrigname completely since
nothing ever touches it.
johannes
------------------------------------------------------------------------------
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.
But none more important than the need to reduce IT complexity
while improving strategic productivity. Learn More!
http://www.accelacomm.com/jaw/sdnl/114/51507609/
prev parent reply other threads:[~2011-12-15 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 8:02 [PATCH] asus-wmi: explicitly set the wireless LED Keng-Yu Lin
[not found] ` <1323244922-2673-1-git-send-email-kengyu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-12-15 7:07 ` Corentin Chary
[not found] ` <CAHR064iBtSTv79BhXt9_mMWugD4U_xLCM4i1wE7PLnZM8pL57g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-15 8:22 ` Johannes Berg
2011-12-15 8:25 ` Corentin Chary
[not found] ` <CAHR064ivFUeGwNAfB1MZO0mrvo+sAcM-cZTjR9wZTaPyWRhzAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-15 8:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323937607.3337.6.camel@jlt3.sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kengyu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox