X86 platform drivers
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: mjg@redhat.com
Cc: platform-driver-x86@vger.kernel.org,
	Bence Lukacs <lukacs.bence1@gmail.com>,
	Carlos Corbacho <carlos@strangeworlds.co.uk>,
	Dmitry Torokhov <dtor@mail.ru>,
	Corentin Chary <corentincj@iksaif.net>,
	Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] acer-wmi: add Acer Extensa 5235 to video backlight vendor
Date: Sat, 05 May 2012 20:26:14 +0800	[thread overview]
Message-ID: <1336220774.5272.3104.camel@linux-s257.site> (raw)
In-Reply-To: <1334739667-20398-1-git-send-email-jlee@suse.com>

於 三,2012-04-18 於 17:01 +0800,Lee, Chun-Yi 提到:
> From: "Lee, Chun-Yi" <jlee@suse.com>
> 
> Acer Extensa 5235 laptop have broken _BCM implemenation, the AML
> code wrote value to EC register but firmware didn't change brighenss.
> 
> Fortunately, the brightness control works on those machines with vendor mode.
> So, add this machine to video backlight vendor mode quirk table.
> 
> Reference: bko#42833
> 	https://bugzilla.kernel.org/show_bug.cgi?id=42833
> 
> Cc: Bence Lukacs <lukacs.bence1@gmail.com>
> Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Thomas Renninger <trenn@suse.de>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
>  drivers/platform/x86/acer-wmi.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c1a3fd8..c2a237f 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -523,6 +523,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
>  		},
>  	},
> +	{
> +		.callback = video_set_backlight_video_vendor,
> +		.ident = "Acer Extensa 5235",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Extensa 5235"),
> +		},
> +	},
>  	{}
>  };
>  

Collected more issue machines need add to quirk table.

I just re-sent patch:
[PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk
table


Thanks
Joey Lee

      reply	other threads:[~2012-05-05 12:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18  9:01 [PATCH] acer-wmi: add Acer Extensa 5235 to video backlight vendor Lee, Chun-Yi
2012-05-05 12:26 ` joeyli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336220774.5272.3104.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=carlos@strangeworlds.co.uk \
    --cc=corentincj@iksaif.net \
    --cc=dtor@mail.ru \
    --cc=lukacs.bence1@gmail.com \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox