From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: [PATCH 2/2] ACER: Fix Smatch double-free issue Date: Thu, 5 Jul 2012 01:30:10 +0200 Message-ID: <1341444610-15067-2-git-send-email-marex@denx.de> References: <1341444610-15067-1-git-send-email-marex@denx.de> Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:53992 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755588Ab2GDXaR (ORCPT ); Wed, 4 Jul 2012 19:30:17 -0400 In-Reply-To: <1341444610-15067-1-git-send-email-marex@denx.de> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: platform-driver-x86@vger.kernel.org Cc: Marek Vasut , Matthew Garrett , Fengguang Wu , joeyli , Dan Carpenter The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor" from Jun 1, 2012, leads to the following Smatch warning: drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy() error: don't call input_free_device() after input_unregister_device() drivers/platform/x86/acer-wmi.c 1883 static void acer_wmi_accel_destroy(void) 1884 { 1885 input_unregister_device(acer_wmi_accel_dev); 1886 input_free_device(acer_wmi_accel_dev); 1887 } Reported-by: Dan Carpenter Signed-off-by: Marek Vasut Cc: Matthew Garrett Cc: Fengguang Wu Cc: joeyli Cc: Dan Carpenter --- drivers/platform/x86/acer-wmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index ae969fd..f4ed2af 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -1883,7 +1883,6 @@ err_free_dev: static void acer_wmi_accel_destroy(void) { input_unregister_device(acer_wmi_accel_dev); - input_free_device(acer_wmi_accel_dev); } static int __init acer_wmi_input_setup(void) -- 1.7.10