X86 platform drivers
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] gmux: Fix backlight set function
Date: Thu, 13 Sep 2012 21:35:14 +0100	[thread overview]
Message-ID: <1347568514.21322.5.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1347566555-9388-1-git-send-email-grant.likely@secretlab.ca>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Thu, 2012-09-13 at 21:02 +0100, Grant Likely wrote:
> In commit 7e30ed6b, "gmux: Add generic write32 function", the new
> gmux_write32() function didn't include the io offset when writing
> registers. This means that backlight update writes never go to the
> right
> place. This patch fixes it.
> 
> Tested on Apple Macbook 8,3 

Aha, thanks. I was going to have to get to that in the next few days.

I also noticed that since updating to the latest kernel and the latest
version of all the patches, I never get Intel graphics output working
after switching. And even the Radeon doesn't work right, if I switch
away and back. X just locks up after a few seconds and the graphics
engine isn't responding.

-- 
dwmw2

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]

  parent reply	other threads:[~2012-09-13 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 20:02 [PATCH] gmux: Fix backlight set function Grant Likely
2012-09-13 20:26 ` Seth Forshee
2012-09-13 20:31   ` Matthew Garrett
2012-09-13 20:35 ` David Woodhouse [this message]
2012-09-14 13:06   ` Grant Likely
2012-09-17  9:37     ` David Woodhouse
2012-10-04 10:53     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347568514.21322.5.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox