From: Roland Stigge <stigge@antcom.de>
To: gregkh@linuxfoundation.org, corentin.chary@gmail.com,
mjg@redhat.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Roland Stigge <stigge@antcom.de>
Subject: [PATCH] samsung-laptop: Set keyboard backlight initially
Date: Sun, 23 Dec 2012 18:21:18 +0100 [thread overview]
Message-ID: <1356283278-5046-1-git-send-email-stigge@antcom.de> (raw)
After boot, /sys/devices/platform/samsung/leds/samsung::kbd_backlight/brightness
shows the maximum value (8) by readout, but the led is off. I need to manually
set it to the respective value to have keyboard backlight.
Fixing via readout-write in samsung_leds_init().
Tested on Samsung NP900X3C.
Signed-off-by: Roland Stigge <stigge@antcom.de>
--
I'm encountering a similar issue after suspend/resume (led is off). Still
wondering if and by which technique I should add a respective .resume() because
the driver currently doesn't have pm support and also doesn't register as a
driver. Any hint appreciated.
Thanks in advance!
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index dd90d15..1d3292c 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1053,6 +1053,7 @@ static int __init samsung_leds_init(struct samsung_laptop *samsung)
ret = led_classdev_register(&samsung->platform_device->dev,
&samsung->kbd_led);
+ kbd_led_set(&samsung->kbd_led, kbd_led_get(&samsung->kbd_led));
}
if (ret)
next reply other threads:[~2012-12-23 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 17:21 Roland Stigge [this message]
2012-12-24 8:41 ` [PATCH] samsung-laptop: Set keyboard backlight initially Corentin Chary
2012-12-24 12:55 ` Roland Stigge
2013-01-03 20:46 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356283278-5046-1-git-send-email-stigge@antcom.de \
--to=stigge@antcom.de \
--cc=corentin.chary@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox