X86 platform drivers
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: Benson Leung <bleung@chromium.org>,
	Yufeng Shen <miletus@chromium.org>,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH] Platform: x86: chromeos_laptop: make dmi_check_callback return 1
Date: Wed, 27 Feb 2013 10:55:59 +0800	[thread overview]
Message-ID: <1361933759.8798.1.camel@phoenix> (raw)

We only care about if there is any successful match from the dmi table
or no match at all, we can make dmi_check_system return immediately if
we have a successful match instead of iterate thorough the whole table.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/platform/x86/chromeos_laptop.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86/chromeos_laptop.c
index 93d6680..b6018d4 100644
--- a/drivers/platform/x86/chromeos_laptop.c
+++ b/drivers/platform/x86/chromeos_laptop.c
@@ -207,7 +207,7 @@ static int __init setup_cyapa_smbus_tp(const struct dmi_system_id *id)
 {
 	/* add cyapa touchpad on smbus */
 	tp = add_smbus_device("trackpad", &cyapa_device);
-	return 0;
+	return 1;
 }
 
 static int __init setup_atmel_224s_tp(const struct dmi_system_id *id)
@@ -219,7 +219,7 @@ static int __init setup_atmel_224s_tp(const struct dmi_system_id *id)
 	/* add atmel mxt touchpad on VGA DDC GMBus */
 	tp = add_probed_i2c_device("trackpad", I2C_ADAPTER_VGADDC,
 				   &atmel_224s_tp_device, addr_list);
-	return 0;
+	return 1;
 }
 
 static int __init setup_atmel_1664s_ts(const struct dmi_system_id *id)
@@ -231,7 +231,7 @@ static int __init setup_atmel_1664s_ts(const struct dmi_system_id *id)
 	/* add atmel mxt touch device on PANEL GMBus */
 	ts = add_probed_i2c_device("touchscreen", I2C_ADAPTER_PANEL,
 				   &atmel_1664s_device, addr_list);
-	return 0;
+	return 1;
 }
 
 
@@ -239,7 +239,7 @@ static int __init setup_isl29018_als(const struct dmi_system_id *id)
 {
 	/* add isl29018 light sensor */
 	als = add_smbus_device("lightsensor", &isl_als_device);
-	return 0;
+	return 1;
 }
 
 static int __init setup_isl29023_als(const struct dmi_system_id *id)
@@ -247,21 +247,21 @@ static int __init setup_isl29023_als(const struct dmi_system_id *id)
 	/* add isl29023 light sensor on Panel GMBus */
 	als = add_i2c_device("lightsensor", I2C_ADAPTER_PANEL,
 			     &isl_als_device);
-	return 0;
+	return 1;
 }
 
 static int __init setup_tsl2583_als(const struct dmi_system_id *id)
 {
 	/* add tsl2583 light sensor on smbus */
 	als = add_smbus_device(NULL, &tsl2583_als_device);
-	return 0;
+	return 1;
 }
 
 static int __init setup_tsl2563_als(const struct dmi_system_id *id)
 {
 	/* add tsl2563 light sensor on smbus */
 	als = add_smbus_device(NULL, &tsl2563_als_device);
-	return 0;
+	return 1;
 }
 
 static struct dmi_system_id __initdata chromeos_laptop_dmi_table[] = {
-- 
1.7.9.5

             reply	other threads:[~2013-02-27  2:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27  2:55 Axel Lin [this message]
2013-02-27  4:17 ` [PATCH] Platform: x86: chromeos_laptop: make dmi_check_callback return 1 Benson Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361933759.8798.1.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=bleung@chromium.org \
    --cc=matthew.garrett@nebula.com \
    --cc=miletus@chromium.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox