From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
peter.p.waskiewicz.jr@intel.com, danders@circuitco.com,
vishal.l.verma@intel.com,
Matthew Garrett <matthew.garrett@nebula.com>,
Grant Likely <grant.likely@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys
Date: Wed, 26 Jun 2013 11:46:26 +0300 [thread overview]
Message-ID: <1372236386.24799.58.camel@smile> (raw)
In-Reply-To: <1ded9714150de50fac7fb6ee82166fbcb5621f7d.1372211451.git.dvhart@linux.intel.com>
On Tue, 2013-06-25 at 18:53 -0700, Darren Hart wrote:
> Configure the four buttons tied to the E6XX GPIO lines on the
> MinnowBoard as keys using the gpio-keys-polled platform driver. From
> left to right, bind them to LEFT, DOWN, UP, RIGHT, similar to the VI
> directional keys.
>
> This is separate from the minnowboard driver to provide users with the
> flexibility to write kernel drivers for their own devices using these GPIO
> lines.
I'm repeating my comment I did early to you.
I think this driver is a wrong approach, since you just use
gpio_keys_polling with custom platform data. So, it should go to the
platform code / board file under arch/x86/platform/minnow/...
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-06-26 8:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1372211451.git.dvhart@linux.intel.com>
2013-06-26 1:53 ` [PATCH 4/8] minnowboard: Add base platform driver for the MinnowBoard Darren Hart
2013-06-26 4:00 ` Olof Johansson
2013-06-26 4:43 ` Darren Hart
2013-06-26 4:52 ` Matthew Garrett
2013-06-26 5:32 ` Darren Hart
2013-06-26 5:36 ` Matthew Garrett
2013-06-26 7:17 ` Darren Hart
2013-06-27 9:14 ` Linus Walleij
2013-06-28 5:43 ` Darren Hart
2013-07-04 16:26 ` Mark Brown
2013-07-20 17:37 ` Linus Walleij
2013-07-21 23:41 ` Mark Brown
2013-10-30 14:18 ` Darren Hart
2013-10-30 21:36 ` Mark Brown
2013-07-22 0:09 ` Grant Likely
2013-07-22 3:27 ` Darren Hart
2013-06-26 1:53 ` [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO Darren Hart
2013-06-26 7:55 ` Andy Shevchenko
2013-06-26 16:21 ` Darren Hart
2013-06-27 8:18 ` Andy Shevchenko
2013-06-28 4:27 ` Darren Hart
2013-06-26 1:53 ` [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys Darren Hart
2013-06-26 8:46 ` Andy Shevchenko [this message]
2013-06-26 16:28 ` Darren Hart
2013-06-26 17:16 ` Greg Kroah-Hartman
2013-06-26 17:23 ` Darren Hart
2013-06-26 19:57 ` Linus Walleij
2013-06-26 21:23 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372236386.24799.58.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=danders@circuitco.com \
--cc=dvhart@linux.intel.com \
--cc=grant.likely@linaro.org \
--cc=hpa@zytor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox