From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys Date: Wed, 26 Jun 2013 10:23:06 -0700 Message-ID: <1372267386.8177.87.camel@envy.home> References: <1ded9714150de50fac7fb6ee82166fbcb5621f7d.1372211451.git.dvhart@linux.intel.com> <1372236386.24799.58.camel@smile> <1372264087.8177.80.camel@envy.home> <20130626171640.GA14661@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([143.182.124.37]:24376 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004Ab3FZRXI (ORCPT ); Wed, 26 Jun 2013 13:23:08 -0400 In-Reply-To: <20130626171640.GA14661@kroah.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Greg Kroah-Hartman Cc: Andy Shevchenko , Olof Johansson , Linux Kernel Mailing List , "H. Peter Anvin" , peter.p.waskiewicz.jr@intel.com, danders@circuitco.com, vishal.l.verma@intel.com, Matthew Garrett , Grant Likely , Linus Walleij , platform-driver-x86@vger.kernel.org On Wed, 2013-06-26 at 10:16 -0700, Greg Kroah-Hartman wrote: > On Wed, Jun 26, 2013 at 09:28:07AM -0700, Darren Hart wrote: > > On Wed, 2013-06-26 at 11:46 +0300, Andy Shevchenko wrote: > > > On Tue, 2013-06-25 at 18:53 -0700, Darren Hart wrote: > > > > Configure the four buttons tied to the E6XX GPIO lines on the > > > > MinnowBoard as keys using the gpio-keys-polled platform driver. From > > > > left to right, bind them to LEFT, DOWN, UP, RIGHT, similar to the VI > > > > directional keys. > > > > > > > > This is separate from the minnowboard driver to provide users with the > > > > flexibility to write kernel drivers for their own devices using these GPIO > > > > lines. > > > > > > I'm repeating my comment I did early to you. > > > > > > I think this driver is a wrong approach, since you just use > > > gpio_keys_polling with custom platform data. So, it should go to the > > > platform code / board file under arch/x86/platform/minnow/... > > > > > > Olof mentinoed something similar. The reason this is separate is that I > > can easily see someone wanting to use these buttons in a different way > > when integrating the MinnowBoard into some kind of product. The > > minnowboard.c driver sets up the fixed functionality GPIO lines, such as > > the LEDs (which can be easily reconfigured via triggers) while this > > driver serves as an example of how the GPIO buttons could be used as > > keys, but if included in the minnowboard driver, users couldn't get the > > fixed functionality without also tying up these GPIO lines. > > > > I could remedy that with driver command-line options, but I know I've > > heard Greg KH discourage their use in the past. > > Ick, yes, never do that type of thing as a command-line option, that's > what device-tree is for :) I suppose when I convert to ACPI drivers I could merge them and have the ACPI table include some data that enabled or disabled things like the minnowboard-keys.... but that seems like more work for the user than it should be to disable the example keys driver. -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel