From: Qipeng Zha <qipeng.zha@intel.com>
To: platform-driver-x86@vger.kernel.org
Cc: dvhart@infradead.org, andriy.shevchenko@linux.intel.com,
qipeng.zha@intel.com,
Ananth Krishna R <ananth.krishna.r@intel.com>,
Bharath K Veera <bharath.k.veera@intel.com>
Subject: [PATCH 2/2] intel_pmc_ipc: avoid pending IPC1 command during legacy suspend
Date: Thu, 18 Feb 2016 02:03:38 +0800 [thread overview]
Message-ID: <1455732218-27283-2-git-send-email-qipeng.zha@intel.com> (raw)
In-Reply-To: <1455732218-27283-1-git-send-email-qipeng.zha@intel.com>
During legacy suspend flow, IPC1 commands are being requested
from opregion driver. But the PMC_IPC1 command will timeout as example:
[ 281.444600] ipc_debug##: ipc_send_command: cmd=0x201ff,
[ 281.444648] wbuf[0]=0x4ea6
[ 281.444668] wbuf[1]=0x0
[ 281.444674] wbuf[2]=0x0
[ 281.444676] wbuf[3]=0x0
[ 284.446467] pmc-ipc-plat INT34D2:00: IPC timed out, TS=0x4, CMD=0x200ff
This is because before the opregion driver could send IPC1 commands,
the PMC_IPC irq is already suspended. Which makes the IPC command to
timeout.
Solution: register pmc_ipc irq as IRQF_NO_SUSPEND
Signed-off-by: Ananth Krishna R <ananth.krishna.r@intel.com>
Signed-off-by: Bharath K Veera <bharath.k.veera@intel.com>
Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>
---
drivers/platform/x86/intel_pmc_ipc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
index abdf67c..140aa77 100644
--- a/drivers/platform/x86/intel_pmc_ipc.c
+++ b/drivers/platform/x86/intel_pmc_ipc.c
@@ -731,7 +731,8 @@ static int ipc_plat_probe(struct platform_device *pdev)
goto err_device;
}
- if (request_irq(ipcdev.irq, ioc, 0, "intel_pmc_ipc", &ipcdev)) {
+ if (request_irq(ipcdev.irq, ioc, IRQF_NO_SUSPEND,
+ "intel_pmc_ipc", &ipcdev)) {
dev_err(&pdev->dev, "Failed to request irq\n");
ret = -EBUSY;
goto err_irq;
--
1.8.3.2
next prev parent reply other threads:[~2016-02-17 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:03 [PATCH 1/2] intel_pmc_ipc: Fix GCR register base address and length Qipeng Zha
2016-02-17 10:58 ` Andy Shevchenko
2016-02-17 18:03 ` Qipeng Zha [this message]
2016-02-18 6:13 ` [PATCH 2/2] intel_pmc_ipc: avoid pending IPC1 command during legacy suspend Darren Hart
2016-02-18 6:14 ` [PATCH 1/2] intel_pmc_ipc: Fix GCR register base address and length Darren Hart
2016-02-18 6:19 ` Zha, Qipeng
2016-02-19 22:37 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455732218-27283-2-git-send-email-qipeng.zha@intel.com \
--to=qipeng.zha@intel.com \
--cc=ananth.krishna.r@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bharath.k.veera@intel.com \
--cc=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox