From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: vadimp@mellanox.com, dvhart@infradead.org, fengguang.wu@intel.com
Cc: davem@davemloft.net, geert@linux-m68k.org,
akpm@linux-foundation.org, kvalo@codeaurora.org,
gregkh@linuxfoundation.org, mchehab@kernel.org,
linux@roeck-us.net, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
Date: Mon, 24 Oct 2016 11:58:45 +0300 [thread overview]
Message-ID: <1477299525.6423.39.camel@linux.intel.com> (raw)
In-Reply-To: <1477226727-160036-1-git-send-email-vadimp@mellanox.com>
On Sun, 2016-10-23 at 12:45 +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
>
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
>
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> tristate "Mellanox platform hotplug driver support"
> default n
Btw, I thought the _default_ is 'n' and thus this line is not needed.
> depends on MLX_PLATFORM
> + select HWMON
> select I2C
> ---help---
> This driver handles hot-plug events for the power
> suppliers, power
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-10-24 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
2016-10-23 14:51 ` Darren Hart
2016-10-24 5:33 ` Vadim Pasternak
2016-10-23 16:57 ` Randy Dunlap
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 17:11 ` Randy Dunlap
2016-10-24 18:10 ` Darren Hart
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 8:58 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477299525.6423.39.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox