From: "Joseph, Jithu" <jithu.joseph@intel.com>
To: "Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ashok Raj <ashok.raj@intel.com>, Tony Luck <tony.luck@intel.com>,
<linux-trace-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
Shankar Ravi V <ravi.v.shankar@intel.com>
Subject: Re: [PATCH v2 3/4] platform/x86/intel/ifs: Add SBAF test support
Date: Fri, 12 Jul 2024 08:34:07 +0530 [thread overview]
Message-ID: <1483b461-25f2-4eb7-95a8-5e150786d956@intel.com> (raw)
In-Reply-To: <7e1e86b9-9578-441f-9f4a-23c274234344@linux.intel.com>
On 7/11/2024 9:28 PM, Kuppuswamy Sathyanarayanan wrote:
>>> +
>>> +static const char * const sbaf_test_status[] = {
>>> + [IFS_SBAF_NO_ERROR] = "SBAF no error",
>>> + [IFS_SBAF_OTHER_THREAD_COULD_NOT_JOIN] = "Other thread could not join.",
>>> + [IFS_SBAF_INTERRUPTED_BEFORE_RENDEZVOUS] = "Interrupt occurred prior to SBAF coordination.",
>>> + [IFS_SBAF_UNASSIGNED_ERROR_CODE3] = "Unassigned error code 0x3",
>>> + [IFS_SBAF_INVALID_BUNDLE_INDEX] = "Non valid sbaf bundles. Reload test image",
>> Non-valid SBAF
>>
>> ...but given your define is named "INVALID", why not use just Invalid
>> SBAF?
>
> Above string is from the specification document.But I think it is ok to use
> "Invalid" or "Non-valid".
>
> Jithu, any concerns?
>
Either seems okay, I think "Non-valid SBAF ..." is a bit more preferable as it is more in line with doc.
Jithu
next prev parent reply other threads:[~2024-07-12 3:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 0:02 [PATCH v2 0/4] Add SBAF test to IFS Kuppuswamy Sathyanarayanan
2024-07-11 0:02 ` [PATCH v2 1/4] platform/x86/intel/ifs: Refactor MSR usage in IFS test code Kuppuswamy Sathyanarayanan
2024-07-11 8:51 ` Ilpo Järvinen
2024-07-11 0:02 ` [PATCH v2 2/4] platform/x86/intel/ifs: Add SBAF test image loading support Kuppuswamy Sathyanarayanan
2024-07-11 9:01 ` Ilpo Järvinen
2024-07-11 0:02 ` [PATCH v2 3/4] platform/x86/intel/ifs: Add SBAF test support Kuppuswamy Sathyanarayanan
2024-07-11 9:44 ` Ilpo Järvinen
2024-07-11 15:58 ` Kuppuswamy Sathyanarayanan
2024-07-12 3:04 ` Joseph, Jithu [this message]
2024-07-12 8:24 ` Ilpo Järvinen
2024-07-11 21:21 ` Ashok Raj
2024-07-12 3:18 ` Joseph, Jithu
2024-07-11 0:02 ` [PATCH v2 4/4] trace: platform/x86/intel/ifs: Add SBAF trace support Kuppuswamy Sathyanarayanan
2024-07-11 9:45 ` Ilpo Järvinen
2024-07-11 23:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483b461-25f2-4eb7-95a8-5e150786d956@intel.com \
--to=jithu.joseph@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox