From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Date: Thu, 08 Jun 2017 08:38:07 -0700 Message-ID: <1496936287.1929.18.camel@perches.com> References: <1495885877-7906-1-git-send-email-pali.rohar@gmail.com> <201705271517.30111@pali> <201705272248.13257@pali> <20170608151618.GE32509@fury> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170608151618.GE32509@fury> Sender: linux-kernel-owner@vger.kernel.org To: Darren Hart , Andy Shevchenko Cc: Pali =?ISO-8859-1?Q?Roh=E1r?= , Andy Shevchenko , Andy Lutomirski , Platform Driver , "linux-kernel@vger.kernel.org" List-Id: platform-driver-x86.vger.kernel.org On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: > On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > > > > On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > > > > wrote: > > > > Okay, got it. But on your opinion does it make sense to do > > > > > > > > pr_info("\tobject_id: %2pE\n", g->object_id); > > > > > > > > instead? > > > > > > > > For ASCII it will go as is previously, otherwise escaping would be > > > > done. > > > > > > Both is OK for me. Do you want to send a new patch with %2pE? > > > > To me it looks slightly cleaner. > > I don't want to let this one fall through the cracks. Pali, is a new one coming? Perhaps pr_info("\t%*pE\n", (int)sizeof(g->object_id), g->object_id);