X86 platform drivers
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: dvhart@infradead.org, andy@infradead.org, jwoithe@just42.net,
	cezary.jackiewicz@gmail.com, corentin.chary@gmail.com,
	laforge@gnumonks.org, coproscefalo@gmail.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] platform/x86: fujitsu-laptop: constify attribute_group structures.
Date: Tue, 11 Jul 2017 16:18:14 +0530	[thread overview]
Message-ID: <1499770100-18632-2-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1499770100-18632-1-git-send-email-arvind.yadav.cs@gmail.com>

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   7474	   1205	     24	   8703	   21ff	drivers/platform/x86/fujitsu-laptop.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   7538	   1141	     24	   8703	   21ff	drivers/platform/x86/fujitsu-laptop.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/platform/x86/fujitsu-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index c1a8528..7973342 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -317,7 +317,7 @@ static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
 	NULL
 };
 
-static struct attribute_group fujitsu_pf_attribute_group = {
+static const struct attribute_group fujitsu_pf_attribute_group = {
 	.attrs = fujitsu_pf_attributes
 };
 
-- 
1.9.1

  reply	other threads:[~2017-07-11 10:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 10:48 [PATCH 0/7] Constify platform/x86 attribute_group structures Arvind Yadav
2017-07-11 10:48 ` Arvind Yadav [this message]
2017-07-11 11:14   ` [PATCH 1/7] platform/x86: fujitsu-laptop: constify " Jonathan Woithe
2017-07-11 10:48 ` [PATCH 2/7] platform/x86: compal-laptop: " Arvind Yadav
2017-07-11 10:48 ` [PATCH 3/7] platform/x86: samsung-laptop: " Arvind Yadav
2017-07-11 10:48 ` [PATCH 4/7] platform/x86: alienware-wmi: " Arvind Yadav
2017-07-11 10:48 ` [PATCH 5/7] platform/x86: panasonic-laptop: " Arvind Yadav
2017-07-11 10:48 ` [PATCH 6/7] platform/x86: asus-wmi: " Arvind Yadav
2017-07-11 10:48 ` [PATCH 7/7] platform/x86: toshiba_acpi: " Arvind Yadav
2017-07-11 16:24 ` [PATCH 0/7] Constify platform/x86 " Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499770100-18632-2-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=andy@infradead.org \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=jwoithe@just42.net \
    --cc=laforge@gnumonks.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox