From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v1] platform/x86: Kconfig: Surround WMI drivers by 'if ACPI_WMI'
Date: Wed, 3 Feb 2021 13:57:10 +0100 [thread overview]
Message-ID: <1508278f-eac4-2df3-ca94-d99f4fd2a3a2@redhat.com> (raw)
In-Reply-To: <CAHp75Vc1EMUKLoBAaUSqD-TeBuSQbe1gHPGjisp_-W7uWyc1ug@mail.gmail.com>
Hi,
On 2/3/21 1:16 PM, Andy Shevchenko wrote:
> On Wed, Feb 3, 2021 at 2:13 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 2/3/21 12:33 PM, Andy Shevchenko wrote:
>>> On Wed, Feb 03, 2021 at 11:55:40AM +0100, Hans de Goede wrote:
>>>> On 2/3/21 11:48 AM, Hans de Goede wrote:
>
> ...
>
>>>> So I still think just sorting the entire bups alphabetically
>>>> is better. We can then also add a comment at the top to please
>>>> keep things sorted alphabetically.
>>>
>>> In long term I prefer split the entire folder to subfolders where you create
>>> a new Kconfig with a rules like alphabetical order or so.
>>>
>>> Shuffling now Kconfig and Makefile w/o above doesn't bring a value in my
>>> opinion.
>>
>> Ok, lets keep things as is for now then and hopefully in the future
>> someone will have some time to clean this up a bit.
>
> Or ask contributors from corresponding companies (Dell, Lenovo, etc)
> to sort this out at least for their devices. Good we have no surface
> issue with this, since it's in a separate (sibling) folder.
The biggest group of drivers seem to be Intel drivers, so perhaps
Intel can set a good example here by moving their drivers to one
or more sub-folders ?
Regards,
Hans
next prev parent reply other threads:[~2021-02-03 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 14:00 [PATCH v1] platform/x86: Kconfig: Surround WMI drivers by 'if ACPI_WMI' Andy Shevchenko
2021-02-03 10:48 ` Hans de Goede
2021-02-03 10:55 ` Hans de Goede
2021-02-03 11:33 ` Andy Shevchenko
2021-02-03 12:11 ` Hans de Goede
2021-02-03 12:16 ` Andy Shevchenko
2021-02-03 12:57 ` Hans de Goede [this message]
2021-02-03 13:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508278f-eac4-2df3-ca94-d99f4fd2a3a2@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox