X86 platform drivers
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	intel-sgx-kernel-dev@lists.01.org
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [intel-sgx-kernel-dev] [PATCH RFC v3 07/12] intel_sgx: driver for Intel Software Guard Extensions
Date: Thu, 02 Nov 2017 12:48:35 -0700	[thread overview]
Message-ID: <1509652115.17230.9.camel@intel.com> (raw)
In-Reply-To: <20171010143258.21623-8-jarkko.sakkinen@linux.intel.com>

On Tue, 2017-10-10 at 17:32 +0300, Jarkko Sakkinen wrote:
> +static int __init sgx_drv_init(void)
> +{
> +	int ret;
> +
> +	ret = sgx_drv_subsys_init();

The return value of sgx_drv_subsys_init is being ignored.

> +
> +	ret = platform_driver_register(&sgx_drv);
> +	if (ret)
> +		sgx_drv_subsys_exit();
> +
> +	return ret;
> +}
> +module_init(sgx_drv_init);
> +
> +static void __exit sgx_drv_exit(void)
> +{
> +	platform_driver_unregister(&sgx_drv);
> +	sgx_drv_subsys_exit();
> +}
> +module_exit(sgx_drv_exit);

  parent reply	other threads:[~2017-11-02 19:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 14:32 [PATCH RFC v3 00/12] Intel(R) SGX Driver Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 01/12] intel_sgx: updated MAINTAINERS Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 02/12] x86: add SGX definition to cpufeature Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 03/12] x86: define the feature control MSR's SGX enable bit Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 04/12] x86: define the feature control MSR's SGX launch control bit Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 05/12] x86: add SGX MSRs to msr-index.h Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 06/12] fs/pipe.c: export create_pipe_files() and replace_fd() Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 08/12] intel_sgx: ptrace() support Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 09/12] intel_sgx: driver documentation Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 10/12] intel_sgx: in-kernel launch enclave Jarkko Sakkinen
2017-11-08 20:07   ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 14:22     ` Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 11/12] intel_sgx: glue code for in-kernel LE Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 12/12] intel_sgx: update IA32_SGXLEPUBKEYHASH* MSRs Jarkko Sakkinen
     [not found] ` <20171010143258.21623-8-jarkko.sakkinen@linux.intel.com>
2017-10-10 15:41   ` [intel-sgx-kernel-dev] [PATCH RFC v3 07/12] intel_sgx: driver for Intel Software Guard Extensions Sean Christopherson
2017-10-11 11:46     ` Jarkko Sakkinen
2017-10-11 15:56       ` Sean Christopherson
2017-10-10 18:26   ` Sean Christopherson
2017-10-13 19:58     ` Jarkko Sakkinen
2017-10-13 20:02       ` Jarkko Sakkinen
2017-10-13 20:08         ` Jarkko Sakkinen
2017-10-13 20:13           ` Jarkko Sakkinen
2017-10-12 16:48   ` Sean Christopherson
2017-10-13 19:16     ` Jarkko Sakkinen
2017-11-02 19:48   ` Sean Christopherson [this message]
2017-11-06  7:23     ` Jarkko Sakkinen
2017-11-02 20:10   ` Sean Christopherson
2017-11-06 11:08     ` Jarkko Sakkinen
2017-11-06 11:33       ` Jarkko Sakkinen
2017-11-06 14:56         ` Sean Christopherson
2017-11-08  6:25           ` Jarkko Sakkinen
2017-11-06 11:39     ` Jarkko Sakkinen
2017-11-06 14:54       ` Sean Christopherson
2017-11-07 18:43         ` Jarkko Sakkinen
2017-11-06 15:54   ` Dave Hansen
2017-11-07 18:47     ` Jarkko Sakkinen
2017-11-07 19:05       ` Dave Hansen
2017-11-14 19:33         ` Jarkko Sakkinen
2017-11-14 21:05           ` Jarkko Sakkinen
2017-11-14 21:12             ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509652115.17230.9.camel@intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=intel-sgx-kernel-dev@lists.01.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox