From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Mario Limonciello <mario.limonciello@dell.com>,
Aleksandr Mishin <amishin@t-argos.ru>
Cc: Hans de Goede <hdegoede@redhat.com>,
Lyndon Sanche <lsanche@lyndeno.ca>, Armin Wolf <W_Armin@gmx.de>,
"Darren Hart (VMware)" <dvhart@infradead.org>,
Edward O'Callaghan <quasisec@google.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] platform/x86: dell-smbios: Fix error path in dell_smbios_init()
Date: Fri, 30 Aug 2024 12:58:39 +0300 [thread overview]
Message-ID: <172501191967.1828.1763222607712237074.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20240830065428.9544-1-amishin@t-argos.ru>
On Fri, 30 Aug 2024 09:54:28 +0300, Aleksandr Mishin wrote:
> In case of error in build_tokens_sysfs(), all the memory that has been
> allocated is freed at end of this function. But then free_group() is
> called which performs memory deallocation again.
>
> Also, instead of free_group() call, there should be exit_dell_smbios_smm()
> and exit_dell_smbios_wmi() calls, since there is initialization, but there
> is no release of resources in case of an error.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: dell-smbios: Fix error path in dell_smbios_init()
commit: ffc17e1479e8e9459b7afa80e5d9d40d0dd78abb
--
i.
prev parent reply other threads:[~2024-08-30 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 12:17 [PATCH] platform/x86: dell-smbios: Fix error path in dell_smbios_init() Aleksandr Mishin
2024-08-29 13:11 ` Ilpo Järvinen
2024-08-30 6:54 ` [PATCH v2] " Aleksandr Mishin
2024-08-30 9:58 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172501191967.1828.1763222607712237074.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=amishin@t-argos.ru \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsanche@lyndeno.ca \
--cc=lvc-project@linuxtesting.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).