From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Corentin Chary <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
Denis Benato <benato.denis96@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jian-Hong Pan <jian-hong@endlessm.com>,
Anton Khirnov <anton@khirnov.net>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led
Date: Wed, 03 Dec 2025 11:47:24 +0200 [thread overview]
Message-ID: <176475524451.7250.10247983674416836381.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20251129101307.18085-3-anton@khirnov.net>
On Sat, 29 Nov 2025 11:13:08 +0100, Anton Khirnov wrote:
> kbd_led_set() can sleep, and so may not be used as the brightness_set()
> callback.
>
> Otherwise using this led with a trigger leads to system hangs
> accompanied by:
> BUG: scheduling while atomic: acpi_fakekeyd/2588/0x00000003
> CPU: 4 UID: 0 PID: 2588 Comm: acpi_fakekeyd Not tainted 6.17.9+deb14-amd64 #1 PREEMPT(lazy) Debian 6.17.9-1
> Hardware name: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B9403CVAR/B9403CVAR, BIOS B9403CVAR.311 12/24/2024
> Call Trace:
> <TASK>
> [...]
> schedule_timeout+0xbd/0x100
> __down_common+0x175/0x290
> down_timeout+0x67/0x70
> acpi_os_wait_semaphore+0x57/0x90
> [...]
> asus_wmi_evaluate_method3+0x87/0x190 [asus_wmi]
> led_trigger_event+0x3f/0x60
> [...]
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led
commit: ccb61a328321ba3f8567e350664c9ca7a42b6c70
--
i.
prev parent reply other threads:[~2025-12-03 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 10:13 [PATCH v2] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led Anton Khirnov
2025-11-29 13:32 ` Andy Shevchenko
2025-11-29 13:54 ` Denis Benato
2025-12-03 9:47 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176475524451.7250.10247983674416836381.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anton@khirnov.net \
--cc=benato.denis96@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=jian-hong@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).