From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Vadim Pasternak <vadimp@nvidia.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 14/42] drivers/platform/mellanox: Convert snprintf to sysfs_emit
Date: Wed, 24 Jan 2024 13:01:05 +0200 (EET) [thread overview]
Message-ID: <1ddc2cc6-1f9c-09c0-acf6-93fa39a10540@linux.intel.com> (raw)
In-Reply-To: <20240116045151.3940401-12-lizhijian@fujitsu.com>
On Tue, 16 Jan 2024, Li Zhijian wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:466:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:584:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:635:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:686:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:737:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:788:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:839:8-16: WARNING: please use sysfs_emit
>
> No functional change intended
>
> CC: Hans de Goede <hdegoede@redhat.com>
> CC: ilpo.jarvinen@linux.intel.com
> CC: Vadim Pasternak <vadimp@nvidia.com>
> CC: platform-driver-x86@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Applied to pdx86 review-ilpo branch.
--
i.
next prev parent reply other threads:[~2024-01-24 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 4:10 [PATCH 00/42] Fix coccicheck warnings Li Zhijian
[not found] ` <20240116045151.3940401-1-lizhijian@fujitsu.com>
2024-01-16 4:51 ` [PATCH 14/42] drivers/platform/mellanox: Convert snprintf to sysfs_emit Li Zhijian
2024-01-24 11:01 ` Ilpo Järvinen [this message]
2024-02-06 2:07 ` (subset) [PATCH 00/42] Fix coccicheck warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ddc2cc6-1f9c-09c0-acf6-93fa39a10540@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox