Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add ovc-capacity-table info

[Hans de Goede <hansg@kernel.org>]

Hi Andy,

On 9-Jun-25 11:34 AM, Andy Shevchenko wrote:
> On Sun, Jun 8, 2025 at 11:41 PM Hans de Goede <hansg@kernel.org> wrote:
>>
>> Add ovc-capacity-table info to the generic battery nodes.
>>
>> The values come from the ug3105 driver which currently hardcodes these
>> values. The ug3105 driver will be modified to stop hardcoding this and
>> instead get the values from device-properties.
> 
> Both looks good to me,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 
> One minor question/nit-pick below.
> 
> ...
> 
>> +static const u32 generic_lipo_4v2_battery_ovc_cap_table0[] = {
>> +       4200000, 100,
>> +       4150000, 95,
>> +       4110000, 90,
>> +       4075000, 85,
>> +       4020000, 80,
>> +       3982500, 75,
>> +       3945000, 70,
>> +       3907500, 65,
>> +       3870000, 60,
>> +       3853333, 55,
>> +       3836667, 50,
>> +       3820000, 45,
>> +       3803333, 40,
>> +       3786667, 35,
>> +       3770000, 30,
>> +       3750000, 25,
>> +       3730000, 20,
>> +       3710000, 15,
>> +       3690000, 10,
>> +       3610000, 5,
>> +       3350000, 0,
> 
> To me it sounds like a percentage and can't go below 0, meaning that
> this is actually a terminator, so no trailing comma is required.

I was already wondering whether to keep the comma or not. I kept
it since this is not a "formal" terminator, like e.g. NULL at
the end of a variable-length array of strings.

Anyways I'm fine with removing it. I'll send a v2 removing it.

Regards,

Hans




> 
>> +};
>> +
>> +static const u32 generic_lipo_hv_4v35_battery_ovc_cap_table0[] = {
>> +       4300000, 100,
>> +       4250000, 96,
>> +       4200000, 91,
>> +       4150000, 86,
>> +       4110000, 82,
>> +       4075000, 77,
>> +       4020000, 73,
>> +       3982500, 68,
>> +       3945000, 64,
>> +       3907500, 59,
>> +       3870000, 55,
>> +       3853333, 50,
>> +       3836667, 45,
>> +       3820000, 41,
>> +       3803333, 36,
>> +       3786667, 32,
>> +       3770000, 27,
>> +       3750000, 23,
>> +       3730000, 18,
>> +       3710000, 14,
>> +       3690000, 9,
>> +       3610000, 5,
>> +       3350000, 0,
> 
> Ditto.
> 
>> +};
>