Re: [PATCH 0/2] platform/x86/intel/pmc: Fix recent instances of -Wmissing-prototypes

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 12/22/23 19:27, Nathan Chancellor wrote:
> As reported by Stephen at [1], there are a few instances of
> -Wmissing-prototypes, which break the build with CONFIG_WERROR=y. This
> series marks these functions as static because they are not used outside
> of these translation units.
> 
> Feel free to squash these into the original changes if the branch is not
> set in stone.
> 
> [1]: https://lore.kernel.org/all/20231222135412.6bd796cc@canb.auug.org.au/

Thank you for your patch-series, I've squashed the patches into
the original commits in my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
pushed to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> Nathan Chancellor (2):
>       platform/x86/intel/pmc: Mark arl_d3_fixup() and arl_resume() as static
>       platform/x86/intel/pmc: Mark lnl_d3_fixup() and lnl_resume() as static
> 
>  drivers/platform/x86/intel/pmc/arl.c | 4 ++--
>  drivers/platform/x86/intel/pmc/lnl.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: 119652b855e6c96676406ee9a7f535f4db4e8eff
> change-id: 20231222-intel-pmc-missing-prototypes-8fb5014b16b8
> 
> Best regards,