From: Armin Wolf <W_Armin@gmx.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous improvements
Date: Fri, 29 Mar 2024 01:23:25 +0100 [thread overview]
Message-ID: <1ff02eec-084b-4d4b-9629-cd1a104e6213@gmx.de> (raw)
In-Reply-To: <CAHp75VcnsxanOpP+v+EFqpO1TLXyuz1_55Qvttrib9=T1Y1Y+Q@mail.gmail.com>
Am 28.03.24 um 09:50 schrieb Andy Shevchenko:
> On Thu, Mar 28, 2024 at 1:35 AM Armin Wolf <W_Armin@gmx.de> wrote:
>> Am 27.03.24 um 22:52 schrieb Andy Shevchenko:
> ...
>
>>> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> that is the reason for removing this?
> Yes, it's a dead code. Likely the cargo cult line was copied from
> another driver.
>
In that case: Reviewed-by: Armin Wolf <W_Armin@gmx.de>
next prev parent reply other threads:[~2024-03-29 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 21:52 [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous improvements Andy Shevchenko
2024-03-27 23:35 ` Armin Wolf
2024-03-28 8:50 ` Andy Shevchenko
2024-03-29 0:23 ` Armin Wolf [this message]
2024-03-29 17:43 ` Andy Shevchenko
2024-04-08 9:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ff02eec-084b-4d4b-9629-cd1a104e6213@gmx.de \
--to=w_armin@gmx.de \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox