From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed Date: Fri, 16 Apr 2010 17:31:27 -0700 Message-ID: <20100416173127.6b968fd4.randy.dunlap@oracle.com> References: <4BC8FF9D.7050500@tremplin-utc.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:18897 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932493Ab0DQAdM convert rfc822-to-8bit (ORCPT ); Fri, 16 Apr 2010 20:33:12 -0400 In-Reply-To: <4BC8FF9D.7050500@tremplin-utc.net> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: =?ISO-8859-1?Q?=C9ric?= Piel Cc: platform-driver-x86@vger.kernel.org, Andrew Morton , "Brown, Len" , Matthew Garrett , Linux Kernel Mailing List On Sat, 17 Apr 2010 02:23:57 +0200 =C9ric Piel wrote: > Many different modules depend on WMI. In Kconfig, some used to "depen= d" > on it, while others "selected" it. As WMI by itself is useless and mo= re > like a library, it's easier for the user to have it automatically > selected whenever needed. It's especially true for options in complet= ely > different places (like LEDS_DELL_NETBOOKS). So we consistently "selec= t" > it. >=20 > Signed-off-by: =C9ric Piel config ACPI_WMI tristate "WMI" depends on ACPI so what happens when one of these configs selects ACPI_WMI but ACPI is not enabled? Hint: that will not enable ACPI. Did you test that kconfig combination? > --- > drivers/leds/Kconfig | 3 ++- > drivers/platform/x86/Kconfig | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 505eb64..71e8a51 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -280,7 +280,8 @@ config LEDS_ADP5520 > =20 > config LEDS_DELL_NETBOOKS > tristate "External LED on Dell Business Netbooks" > - depends on X86 && ACPI_WMI > + depends on X86 > + select ACPI_WMI > help > This adds support for the Latitude 2100 and similar > notebooks that have an external LED. > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kcon= fig > index 7bec458..9808ef3 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -89,8 +89,8 @@ config DELL_LAPTOP > =20 > config DELL_WMI > tristate "Dell WMI extras" > - depends on ACPI_WMI > depends on INPUT > + select ACPI_WMI > ---help--- > Say Y here if you want to support WMI-based hotkeys on Dell lapto= ps. > =20 > @@ -136,9 +136,9 @@ config TC1100_WMI > =20 > config HP_WMI > tristate "HP WMI extras" > - depends on ACPI_WMI > depends on INPUT > depends on RFKILL || RFKILL =3D n > + select ACPI_WMI > help > Say Y here if you want to support WMI-based hotkeys on HP laptops = and > to read data from WMI such as docking or ambient light sensor stat= e. > @@ -387,9 +387,9 @@ config EEEPC_LAPTOP > =20 > config EEEPC_WMI > tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)" > - depends on ACPI_WMI > depends on INPUT > depends on EXPERIMENTAL > + select ACPI_WMI > ---help--- > Say Y here if you want to support WMI-based hotkeys on Eee PC lap= tops. > =20 > @@ -419,9 +419,9 @@ config ACPI_WMI > =20 > config MSI_WMI > tristate "MSI WMI extras" > - depends on ACPI_WMI > depends on INPUT > depends on BACKLIGHT_CLASS_DEVICE > + select ACPI_WMI > select INPUT_SPARSEKMAP > help > Say Y here if you want to support WMI-based hotkeys on MSI laptops= =2E > --=20 --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe platform-driv= er-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html