From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Ds, Sreedhara" <sreedhara.ds@intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Cox, Alan" <alan.cox@intel.com>
Subject: Re: intel_scu_ipc: Fix to overcome late initialization of scu ipc driver
Date: Sun, 30 May 2010 18:43:52 +0100 [thread overview]
Message-ID: <20100530174352.GA2354@srcf.ucam.org> (raw)
In-Reply-To: <0AE3E14D83C76F4994657326177D1FF9042CE9F774@bgsmsx501.gar.corp.intel.com>
On Sun, May 30, 2010 at 11:10:03PM +0530, Ds, Sreedhara wrote:
> -static void __exit intel_scu_ipc_exit(void)
> -{
> - pci_unregister_driver(&ipc_driver);
> -}
> -
> MODULE_AUTHOR("Sreedhara DS <sreedhara.ds@intel.com>");
> MODULE_DESCRIPTION("Intel SCU IPC driver");
> MODULE_LICENSE("GPL");
>
> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);
This is wrong. If it can't be a module then delete all the other module
code from the driver and change it to a bool in Kconfig. And don't use
fs_initcall - subsys or arch would seem more reasonable, but you're not
describing the problem terribly clearly. Which drivers are getting
initialised before this?
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-05-30 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 17:40 intel_scu_ipc: Fix to overcome late initialization of scu ipc driver Ds, Sreedhara
2010-05-30 17:43 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530174352.GA2354@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan.cox@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sreedhara.ds@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox