From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: alan-jenkins@tuffmail.co.uk, platform-driver-x86@vger.kernel.org,
mjg@redhat.com, don@syst.com.br, rpurdie@rpsys.net
Subject: Re: [PATCH] classmate-laptop: should check for NULL as retval for rfkill_alloc
Date: Wed, 9 Jun 2010 16:49:32 -0300 [thread overview]
Message-ID: <20100609194931.GC2551@barata.holoscopio.com> (raw)
In-Reply-To: <1276112777.14580.24.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
On Wed, Jun 09, 2010 at 09:46:17PM +0200, Johannes Berg wrote:
> On Wed, 2010-06-09 at 16:39 -0300, Thadeu Lima de Souza Cascardo wrote:
>
> > + /*
> > + * If RFKILL is disabled, rfkill_alloc will return ERR_PTR(-ENODEV).
> > + * This is OK, however, since all other uses of the device will not
> > + * derefence it.
> > + */
> > + if (!ipml->rf) {
>
> the ! shouldn't be there
>
> johannes
>
Sorry for that. The else case is unneeded too. Removed in the next
patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-06-09 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:15 [PATCH] classmate-laptop: Add RFKILL support Thadeu Lima de Souza Cascardo
2010-04-27 16:22 ` Matthew Garrett
2010-04-27 16:32 ` Thadeu Lima de Souza Cascardo
2010-05-07 18:18 ` Matthew Garrett
2010-06-09 10:28 ` Alan Jenkins
2010-06-09 18:19 ` Thadeu Lima de Souza Cascardo
2010-06-09 18:32 ` Johannes Berg
2010-06-09 18:58 ` Thadeu Lima de Souza Cascardo
2010-06-09 19:39 ` [PATCH] classmate-laptop: should check for NULL as retval for rfkill_alloc Thadeu Lima de Souza Cascardo
2010-06-09 19:46 ` Johannes Berg
2010-06-09 19:48 ` Thadeu Lima de Souza Cascardo
2010-06-09 19:49 ` Thadeu Lima de Souza Cascardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609194931.GC2551@barata.holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=don@syst.com.br \
--cc=johannes@sipsolutions.net \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox