From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Daniel Oliveira Nascimento <don@syst.com.br>,
Matthew Garrett <mjg@redhat.com>,
Richard Purdie <rpurdie@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] classmate-laptop: make needlessly global symbols static
Date: Wed, 7 Jul 2010 23:42:27 -0300 [thread overview]
Message-ID: <20100708024226.GA19890@barata.holoscopio.com> (raw)
In-Reply-To: <1278553670.7162.4.camel@mola>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
On Thu, Jul 08, 2010 at 09:47:50AM +0800, Axel Lin wrote:
> cmpc_accel_sensitivity_attr is needlessly defined global.
> This patch makes the symbol static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/classmate-laptop.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 3bf399f..6c63303 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
> return strnlen(buf, count);
> }
>
> -struct device_attribute cmpc_accel_sensitivity_attr = {
> +static struct device_attribute cmpc_accel_sensitivity_attr = {
> .attr = { .name = "sensitivity", .mode = 0660 },
> .show = cmpc_accel_sensitivity_show,
> .store = cmpc_accel_sensitivity_store
> --
> 1.5.4.3
>
>
>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-07-08 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 1:47 [PATCH] classmate-laptop: make needlessly global symbols static Axel Lin
2010-07-08 2:42 ` Thadeu Lima de Souza Cascardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708024226.GA19890@barata.holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=don@syst.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox