Re: [PATCH 01/10] WMI: remove EC region handler when _WDG parsing fails

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Aug 26, 2010 at 12:14:42AM -0700, Dmitry Torokhov wrote:
> Driver initialization was forgetting to remove EC address space handler
> in cases when parse_wdg() method failed.
> 
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

*PING* for this and the other 9 in these series...

Thanks.

> ---
> 
>  drivers/platform/x86/wmi.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index b2978a0..7a77f03 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -968,12 +968,17 @@ static int acpi_wmi_add(struct acpi_device *device)
>  						    ACPI_ADR_SPACE_EC,
>  						    &acpi_wmi_ec_space_handler,
>  						    NULL, NULL);
> -	if (ACPI_FAILURE(status))
> +	if (ACPI_FAILURE(status)) {
> +		printk(KERN_ERR PREFIX "Error installing EC region handler\n");
>  		return -ENODEV;
> +	}
>  
>  	status = parse_wdg(device->handle);
>  	if (ACPI_FAILURE(status)) {
> -		printk(KERN_ERR PREFIX "Error installing EC region handler\n");
> +		acpi_remove_address_space_handler(device->handle,
> +						  ACPI_ADR_SPACE_EC,
> +						  &acpi_wmi_ec_space_handler);
> +		printk(KERN_ERR PREFIX "Failed to parse WDG method\n");
>  		return -ENODEV;
>  	}
>  
> 

-- 
Dmitry