From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Date: Wed, 27 Oct 2010 19:42:37 -0200 Message-ID: <20101027214237.GD27847@khazad-dum.debian.net> References: <1288088743-3725-1-git-send-email-julia@diku.dk> <1288088743-3725-9-git-send-email-julia@diku.dk> <20101027010908.GA29299@khazad-dum.debian.net> <20101027035449.GB6062@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out2.smtp.messagingengine.com ([66.111.4.26]:42499 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932602Ab0J0Vmn (ORCPT ); Wed, 27 Oct 2010 17:42:43 -0400 Content-Disposition: inline In-Reply-To: <20101027035449.GB6062@bicker> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Dan Carpenter , Julia Lawall , Henrique de Moraes Holschuh , kernel-janitors@vger.kernel.org, Matthew Garrett On Wed, 27 Oct 2010, Dan Carpenter wrote: > On Tue, Oct 26, 2010 at 11:09:08PM -0200, Henrique de Moraes Holschuh wrote: > > On Tue, 26 Oct 2010, Julia Lawall wrote: > > > From: Julia Lawall > > > > > > Delete successive assignments to the same location. > > > > There are often results of mismerges or other assorted screw ups, often > > done by the maintainer itself (e.g. me in thinkpad-acpi's case) during > > development. > > > > The patch is correct, and I thank you for the head's up. But let me > > track down what caused it first, hmm? I also highly recommend that this > > should be done in all cases you find, instead of just blindly fixing the > > assignment. > > I've reviewed the entire patchset per your suggestion and Julia > obviously didn't do it blindly. It all looks good. The patcheset fixes > a number of bugs. Thank you, Dan and Julia. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh