Re: [PATCH 0/4] Add new wmi support to acer-wmi driver

[Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On Sat, Dec 04, 2010 at 09:03:22AM +0800, Lee, Chun-Yi wrote:
> Hi Matthew, 
> 
> These patches add new wmi support to acer-wmi driver, included the following
> functions:
> 
> - Acer wmi hotkey events:
>   Acer BIOS applied wmi hotkey events from 2010, this patch adds support.
> 
> - Enabled Acer Launch Manager mode:
>   Directly enable it to avoid the raw EC behavior conflict with rfkill-input or
>   userland solution.
> 
> - Add 3G rfkill sysfs file:
>   Provide interface to userland for enable/disable 3G function by wmi method.
> 
> - Detect the WiFi/Bluetooth/3G devices available:
>   Look for OEM type AAh in dmi to get the WiFi/BT/3G devices available.
> 

Please, add a subsystem/driver prefix to the summary like:

acer-wmi: Add 3G rfkill sysfs file.

Otherwise, any person reading summaries will ask perself: adding such
file to what!?!

Regards,
Cascardo.

> Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> Reviewed-by: Thomas Renninger <trenn@suse.de>
> 
> Lee, Chun-Yi (4):
>   Add acer wmi hotkey events support
>   Enabled Acer Launch Manager mode
>   Add 3G rfkill sysfs file
>   Detect the WiFi/Bluetooth/3G devices available
> 
>  drivers/platform/x86/Kconfig    |    2 +
>  drivers/platform/x86/acer-wmi.c |  400 ++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 394 insertions(+), 8 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]