From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, carlos@strangeworlds.co.uk,
stable@kernel.org, ceolin@ulevel.com
Subject: Re: [PATCH] wmi: use memcmp instead of strncmp to compare GUIDs
Date: Mon, 6 Dec 2010 20:13:46 -0200 [thread overview]
Message-ID: <20101206221345.GG4187@barata.holoscopio.com> (raw)
In-Reply-To: <20101206220231.GB1139@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Mon, Dec 06, 2010 at 10:02:31PM +0000, Matthew Garrett wrote:
> Applied to -next, thanks.
>
> --
> Matthew Garrett | mjg59@srcf.ucam.org
Hello, Matthew.
I consider this one a serious bug and with a trivial fix that should go
to Linus, for the next release candidate. I also consider it should go
to stable releases, and that's why I'm copying stable.
Any out-of-tree wmi driver written for systems with two or more GUIDs
containing any '\0' byte with a common prefix will fail to load because
of this bug. I've hit that, and that's how I found the bug.
Regards,
Cascardo.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-12-06 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 21:46 [PATCH] wmi: use memcmp instead of strncmp to compare GUIDs Thadeu Lima de Souza Cascardo
2010-11-28 22:31 ` Jesper Juhl
2010-12-06 22:02 ` Matthew Garrett
2010-12-06 22:13 ` Thadeu Lima de Souza Cascardo [this message]
2010-12-06 22:17 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206221345.GG4187@barata.holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=carlos@strangeworlds.co.uk \
--cc=ceolin@ulevel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox