From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 4/7] ideapad: select INPUT_SPARSEKMAP Date: Thu, 9 Dec 2010 00:13:30 -0800 Message-ID: <20101209081329.GC6233@core.coreip.homeip.net> References: <1291881376-4729-1-git-send-email-ike.pan@canonical.com> <1291881440-4846-1-git-send-email-ike.pan@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:34506 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753432Ab0LIINh (ORCPT ); Thu, 9 Dec 2010 03:13:37 -0500 Content-Disposition: inline In-Reply-To: <1291881440-4846-1-git-send-email-ike.pan@canonical.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Ike Panhc Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, Matthew Garrett , David Woodhouse , Dave Hansen On Thu, Dec 09, 2010 at 03:57:20PM +0800, Ike Panhc wrote: > Thanks for Dave Hansen report the problem. If CONFIG_INPUT_SPARSEKMAP is not > set, when building, you will have error message: > > ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined! > ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined! > ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined! > > To select INPUT_SPARSEKMAP solve this issue. > > Ref: http://lkml.org/lkml/2010/12/2/340 > I'd recommend folding this patch together with the patch that introduces sparse keymap usage. Leaving them separated served only to risk compile errors during bisecting. Thanks. -- Dmitry