From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Jeff Chua <jeff.chua.linux@gmail.com>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management
Date: Sun, 23 Jan 2011 21:35:32 +0100 [thread overview]
Message-ID: <201101232135.32510.rjw@sisk.pl> (raw)
In-Reply-To: <20110123182037.GH24071@khazad-dum.debian.net>
On Sunday, January 23, 2011, Henrique de Moraes Holschuh wrote:
> On Sat, 22 Jan 2011, Rafael J. Wysocki wrote:
> > > I discovered CONFIG_THINKPAD_ACPI caused suspend-to-disk to hang. I
> > > need the Thinkpad ACPI to control the fan and bluetooth. It looks like
> > > the thinkpad acpi is trying acquire locks while suspending. Disabling
> > > cmos, light, led and hotkeys makes suspend-to-disk works again.
> >
> > Well, we should tell the thinkpad_acpi maintainer about that, then (CCed).
>
> What are the requirements re. mutexes for sleep-to-disk versus sleep-to-ram?
No difference. Basically, there are two differences between suspend and
hibernation, as far as drivers are concerned:
(1) It's better to use the ->freeze()/->thaw() and ->poweroff()/->restore()
callbacks for hibernation.
(2) It may be _much_ more difficult to get free memory during hibernation
(so theoretically attempts to get memory during hibernation are more likely
to block).
> Did something change in that area that caused the driver to hang? A pointer
> to the ML threads, documentation, or patchset/git commit with those changes
> would be enough answer, and I will pursue it from there.
I'm not aware of any such changes.
Besides, the problem reported by Jeff seems to be caused by CPU hotplug.
Thanks,
Rafael
next prev parent reply other threads:[~2011-01-23 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201101201226.41021.rjw@sisk.pl>
[not found] ` <201101212206.37469.rjw@sisk.pl>
[not found] ` <AANLkTimEoAhO9TRx4Aq7NnTTt6G-u+cHJRyAMjSAJgTm@mail.gmail.com>
2011-01-22 9:13 ` [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Rafael J. Wysocki
2011-01-23 18:20 ` Henrique de Moraes Holschuh
2011-01-23 20:35 ` Rafael J. Wysocki [this message]
2011-01-23 23:15 ` Henrique de Moraes Holschuh
2011-01-24 21:37 ` Rafael J. Wysocki
2011-01-25 9:43 Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101232135.32510.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi@hmh.eng.br \
--cc=jeff.chua.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox