Re: [PATCH] intel_mid_powerbtn: add power button driver for Medfield platform

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Jan 26, 2011 at 09:57:16AM +0000, Alan Cox wrote:
> +
> +	ret = request_threaded_irq(priv->irq, NULL, mfld_pb_isr,
> +				   0, DRIVER_NAME, priv);
> +	if (ret) {
> +		dev_err(&pdev->dev,
> +			"unable to request irq %d for mfld power button\n",
> +									irq);
> +		goto fail;
> +	}
> +
> +	ret = input_register_device(input);
> +	if (ret == 0)
> +		return 0;
> +
> +	dev_err(&pdev->dev, "unable to register input dev, error %d\n", ret);
> +	free_irq(priv->irq, priv);
> +
> +fail:
> +	platform_set_drvdata(pdev, NULL);
> +	input_free_device(input);
> +	kfree(priv);
> +	return ret;
> +}
> +

Ugh, mixing 2 styles of error handling like this is not the best idea
IMO. Could you please adjust so that all error handling branches out of
line, like virtually every other driver we have in the tree?

Thanks.

-- 
Dmitry