X86 platform drivers
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: mjg@redhat.com, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] intel_mid_powerbtn: add power button driver for Medfield platform (#3)
Date: Wed, 2 Feb 2011 09:00:09 -0800	[thread overview]
Message-ID: <20110202170009.GC3178@core.coreip.homeip.net> (raw)
In-Reply-To: <20110202101745.647e9db2@lxorguk.ukuu.org.uk>

On Wed, Feb 02, 2011 at 10:17:45AM +0000, Alan Cox wrote:
> On Sun, 30 Jan 2011 12:39:50 -0800
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> 
> > On Thu, Jan 27, 2011 at 01:52:13PM +0000, Alan Cox wrote:
> > > From: Hong Liu <hong.liu@intel.com>
> > > 
> > > The power button is connected to MSIC on Medfield, we will get two
> > > interrupts from IOAPIC when pressing or releasing the power button.
> > > 
> > > Signed-off-by: Hong Liu <hong.liu@intel.com>
> > > [Minor fixes as noted by Dmitry]
> > > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > 
> > Acked-by: Dmitry Torokhov <dtor@mail.ru>
> > 
> > Input parts look good to me but you might want to fold in the following
> > patch.
> 
> Ok I wouldn't move the module_init/exit around like that but no big deal
> 8)

Yeah, I can't myself decide which style I like better :)

Well, anyway, aside from MODULE_ALIAS() anything else can be cut from
that patch so I'll leave it to Matthew to decide what he likes best.

Thanks.

-- 
Dmitry

  reply	other threads:[~2011-02-02 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 13:52 [PATCH] intel_mid_powerbtn: add power button driver for Medfield platform (#3) Alan Cox
2011-01-30 20:39 ` Dmitry Torokhov
2011-02-02 10:17   ` Alan Cox
2011-02-02 17:00     ` Dmitry Torokhov [this message]
2011-02-07 19:47 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202170009.GC3178@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox