From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Koerber,
Philip (GE Intelligent Platforms)" <Philip.Koerber@ge.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
Date: Mon, 7 Feb 2011 11:16:44 -0800 [thread overview]
Message-ID: <20110207111644.73878813@jbarnes-desktop> (raw)
In-Reply-To: <20110207191321.GA19838@srcf.ucam.org>
On Mon, 7 Feb 2011 19:13:21 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Fri, Feb 04, 2011 at 09:11:56AM -0800, Jesse Barnes wrote:
> > > +++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
> > > @@ -1399,6 +1399,10 @@
> > > limits = &ips_lv_limits;
> > > else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> > > limits = &ips_ulv_limits;
> > > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
> > > + limits = &ips_sv_limits;
> > > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
> > > + limits = &ips_sv_limits;
> > > else {
> > > dev_info(&ips->dev->dev, "No CPUID match found.\n");
> > > goto out;
> >
> > Yep, that's fine with me, thanks for the patch!
>
> Are these the only two embedded Arrandales? Is there really no MSR that
> gives you the voltage range?
AFAIK this is the same method the Windows driver uses, so I don't think
so.
Fortunately the on-die integration in Sandy Bridge makes all this
unnecessary, so I don't expect you'll have to continually add entries
to this list over time.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2011-02-07 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 14:55 [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo Koerber, Philip (GE Intelligent Platforms)
2011-02-04 17:11 ` Jesse Barnes
2011-02-07 19:13 ` Matthew Garrett
2011-02-07 19:16 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207111644.73878813@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=Philip.Koerber@ge.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox