From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 Date: Thu, 24 Feb 2011 23:18:28 -0800 Message-ID: <20110225071827.GA14053@core.coreip.homeip.net> References: <1298611140-21573-1-git-send-email-keng-yu.lin@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:40630 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753462Ab1BYHSi (ORCPT ); Fri, 25 Feb 2011 02:18:38 -0500 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Corentin Chary Cc: Keng-Yu Lin , Matthew Garrett , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, tyson.chen@canonical.com On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin wrote: > > Signed-off-by: Keng-Yu Lin > > --- > > =A0drivers/platform/x86/eeepc-wmi.c | =A0 =A02 +- > > =A01 files changed, 1 insertions(+), 1 deletions(-) > > > > https://bugs.freedesktop.org/show_bug.cgi?id=3D31333 > > > > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x8= 6/eeepc-wmi.c > > index d399775..da00cbc 100644 > > --- a/drivers/platform/x86/eeepc-wmi.c > > +++ b/drivers/platform/x86/eeepc-wmi.c > > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[= ] =3D { > > =A0 =A0 =A0 =A0{ KE_KEY, 0x32, { KEY_MUTE } }, > > =A0 =A0 =A0 =A0{ KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > > =A0 =A0 =A0 =A0{ KE_KEY, 0x5d, { KEY_WLAN } }, > > - =A0 =A0 =A0 { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > > + =A0 =A0 =A0 { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > > =A0 =A0 =A0 =A0{ KE_KEY, 0x82, { KEY_CAMERA } }, > > =A0 =A0 =A0 =A0{ KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > > =A0 =A0 =A0 =A0{ KE_KEY, 0x88, { KEY_WLAN } }, >=20 > Hum, I'm not very comfortable with this patch now that we got > KEY_TOUCHPAD_TOGGLE. > I know, it doesn't work with current Xorg, but if we continue to > workaround that, it'll never be fixed. >=20 > Dmitry, Matthew, any advice ? I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace should use udev's key re-mapping facilities while X is unable to proces= s keycodes above 255 to adjust to the keycode du jour. If all kernel drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much easier (the utility would simply check capabilities for KEY_TOUCHPAD_TOGGLE and do the remap). Thanks. --=20 Dmitry