From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Date: Fri, 25 Mar 2011 09:14:05 -0700 Message-ID: <20110325161405.GC5099@core.coreip.homeip.net> References: <20110324195720.GB31713@thinkpad-t410> <1300997035-14104-2-git-send-email-seth.forshee@canonical.com> <20110325135311.GA14328@thinkpad-t410> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:35579 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853Ab1CYQOL (ORCPT ); Fri, 25 Mar 2011 12:14:11 -0400 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Corentin Chary Cc: Chris Bagwell , Matthew Garrett , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Seth Forshee On Fri, Mar 25, 2011 at 02:05:18PM +0000, Corentin Chary wrote: > On Fri, Mar 25, 2011 at 1:53 PM, Seth Forshee > wrote: > > > > I guess it depends on what key events we want on a press-and-hold. > > Remember that you're going to get a scan code sequence like "0xe4 0= xea > > 0xea ... 0xea 0xe5", so with my implementation you get > > > > =A0KEY_PROG2 press > > =A0KEY_PROG2 release > > > > With yours > > > > =A0KEY_HOME press > > =A0KEY_PROG2 press > > =A0KEY_PROG2 release > > =A0// KEY_PROG2 press/release repeats every 0.5 secs while button h= eld > > =A0KEY_HOME release > > > > At minimum I'd think we'd want to only send a single PROG2 press/re= lease > > for button hold. My thought was that you'd only want to get the cod= e for > > 0xe4 or 0xea, not both, but I suppose that's debatable. >=20 > If you keep a keyboard key pressed, you want multiple events, not one= right ? > I think it's important not to loose informations. If someone keep thi= s > key pressed more than 1.5 second, I think it's good idea to send > multiple KEY_PROG2. You can have input autorepeat facilities do that for you. If you want t= o do this yourself then the proper value for repeated events is _2_, not 1, or they will be dropped as duplicates. >=20 > About KEY_HOME press / release, and filtering KEY_HOME after > KEY_PROG2, I'm not sure. So if you really want it, and nobody > complains, I'll be happy to accept your patch. >=20 > > And back to the question of KEY_HOME -- that's not really what you = want, > > is it? As in "move cursor to start of line"? >=20 > Ho .. right, that's what mean KEY_HOME :/. So no, I don't want that..= =2E > What about: > - KEY_CYCLEWINDOWS > - KEY_COMPUTER > - KEY_HOMEPAGE > - KEY_DASHBOARD >=20 > I think KEY_HOMEPAGE is the best choice. No, KEY_HOMEPAGE should cause your browser to go to your home page. Wha= t you want is either: #define KEY_CONFIG 171 /* AL Consumer Control Configuration= */ #define KEY_DASHBOARD 204 /* AL Dashboard */ ("AL" stands for "Application Launcher", "AC" for 'Application Control"= , matched loosely to HUT tables). Thanks. --=20 Dmitry