From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Date: Sun, 27 Mar 2011 10:13:05 -0700 Message-ID: <20110327171304.GD30244@core.coreip.homeip.net> References: <20110324195720.GB31713@thinkpad-t410> <1300997035-14104-2-git-send-email-seth.forshee@canonical.com> <20110325135311.GA14328@thinkpad-t410> <20110325161405.GC5099@core.coreip.homeip.net> <20110325162850.GD14328@thinkpad-t410> <20110325170333.GD5099@core.coreip.homeip.net> <20110325185824.GE14328@thinkpad-t410> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:62900 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753512Ab1C0RNL (ORCPT ); Sun, 27 Mar 2011 13:13:11 -0400 Content-Disposition: inline In-Reply-To: <20110325185824.GE14328@thinkpad-t410> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Corentin Chary , Chris Bagwell , Matthew Garrett , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kern On Fri, Mar 25, 2011 at 01:58:24PM -0500, Seth Forshee wrote: > On Fri, Mar 25, 2011 at 10:03:33AM -0700, Dmitry Torokhov wrote: > > > So, would the following make sense (KEY_TBD is may abbreviation for "key > > > to be determinded"): > > > > > > - On press (0xe4), send KEY_TBD, value = 1 > > > - On hold (0xea), send KEY_TBD, value = 2 > > > - On release (0xe5), send KEY_TBD, value = 0 > > > > Yes. > > There's a little problem with this. The driver uses sparse-keymap, which > calls input_report_key(), which is doing this: > > input_event(dev, EV_KEY, code, !!value); Ah, right, it really did not have in mind passing on auto-repeating keys as is when it was written. > > I don't see the hold events in userspace, so they must be getting > dropped as duplicates as you suggested. > > I'm not sure who is at fault here. Should input_report_key() not be > forcing value to 0 or 1? Or should sparse-keymap be calling > input_event() directly? Or is sparse-keymap the wrong tool for handling > keys this way? I do not thik we shoudl burden sparse-keymap with handling repeats. Just mark the device as auto-repeating (by setting EV_REP bit) and let input core autorepeat logic do it for you. Thanks. -- Dmitry