Re: [PATCH] acer-wmi: schedule threeg and interface sysfs for feature removal

[Thomas Renninger <trenn@suse.de>]

On Monday, May 30, 2011 02:21:40 AM Lee, Chun-Yi wrote:
> we can now autodetect internal 3G device and already have the threeg
> rfkill device. So, we plan to remove threeg sysfs support for it's no
> longer necessary.
> 
> We also plan to remove interface sysfs file that exposed which ACPI-WMI
> interface that was used by acer-wmi driver. It will replaced by information
> log when acer-wmi initial.
> 
> We keep it around for userspace compatibility reasons, schedule removal
> in 2012.

...

> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1495539..7e7e668 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1396,6 +1396,8 @@ static ssize_t show_bool_threeg(struct device *dev,
>  {
>  	u32 result; \
>  	acpi_status status;
> +
> +	pr_info("This threeg sysfs will be removed in 2012.");
You could also add:
            " - used by: %s\n", current->comm);
then it's easier to identify and fix the app still making use of it.


>  	if (wmi_has_guid(WMID_GUID3))
>  		status = wmid3_get_device_status(&result,
>  				ACER_WMID3_GDS_THREEG);
> @@ -1421,6 +1423,7 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
>  static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
>  	char *buf)
>  {
> +	pr_info("This interface sysfs will be removed in 2012.");
Same.
>  	switch (interface->type) {
>  	case ACER_AMW0:
>  		return sprintf(buf, "AMW0\n");

   Thomas