From: Matthew Garrett <mjg59@srcf.ucam.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] dell-laptop: support synaptics touchpad led
Date: Thu, 2 Jun 2011 03:23:07 +0100 [thread overview]
Message-ID: <20110602022307.GA21657@srcf.ucam.org> (raw)
In-Reply-To: <BANLkTi=LByUkAL6WKCMYtY2dDJ8xi0xk7g@mail.gmail.com>
On Thu, Jun 02, 2011 at 09:30:56AM +0800, AceLan Kao wrote:
> Mattew,
>
> Dell tells us that they will use the same touchpad chip for their products,
> with the same touchpad LED layout, so I place the code in the dell-laptop.
Forever? I don't believe it's possible for Dell to guarantee that. The
command sequenece is sent to the touchpad, so it needs to go in the
touchpad driver.
> And F22 already map to enable/disable touchpad in X, BIOS and synaptics driver
> do nothing for this event, and my code only turns on/off the touchpad LED,
> not enable/disable the touchpad.
If this were to be done in kernel then it should be via a notifier chain
to the touchpad driver, but I suspect that you'd still get pushback on
that. It's better to leave this kind of thing to userland.
> BIOS should manage this kind of action to enable/disable touchpad and
> the LED, but Dell doesn't want to modify their BIOS to do that, since
> the touchpad driver of MS Windows manages to enable/disable touchpad
> and the LED by themselves, so Linux should do the same thing as
> Windows does.
>
> That's why we need those code and why I think dell-laptop is a good
> place for them.
I'm afraid not. dell-laptop only contains code that speaks to
dell-specific hardware. It seems likely that this command sequence
performs LED control via the touchpad rather than via any dell-specific
mechanism, so the code needs to go in the touchpad driver.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-06-02 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 8:34 [PATCH] dell-laptop: support synaptics touchpad led AceLan Kao
2011-06-01 13:31 ` Matthew Garrett
2011-06-02 1:30 ` AceLan Kao
2011-06-02 2:05 ` Chris Bagwell
2011-06-02 3:18 ` AceLan Kao
2011-06-02 2:23 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602022307.GA21657@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acelan.kao@canonical.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox