X86 platform drivers
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
	Seth Forshee <seth.forshee@canonical.com>,
	Corentin Chary <corentincj@iksaif.net>,
	"open list:ASUS NOTEBOOKS AN..."
	<acpi4asus-user@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/16] asus-wmi: Enable autorepeat for hotkey input device
Date: Fri, 1 Jul 2011 15:15:58 +0100	[thread overview]
Message-ID: <20110701141558.GB1363@srcf.ucam.org> (raw)
In-Reply-To: <1309512881-2901-5-git-send-email-corentin.chary@gmail.com>

On Fri, Jul 01, 2011 at 11:34:29AM +0200, Corentin Chary wrote:
>  	asus->inputdev->id.bustype = BUS_HOST;
>  	asus->inputdev->dev.parent = &asus->platform_device->dev;
> +	__set_bit(EV_REP, asus->inputdev->evbit);

set_bit()? I guess it doesn't make much difference in this case, it just 
seems neater to use the non __ version.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2011-07-01 14:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  9:34 [PATCH 00/16] acpi4asus updates for 3.1 Corentin Chary
2011-07-01  9:34 ` [PATCH 01/16] asus-wmi: fix hwmon/pwm1 Corentin Chary
2011-07-01  9:34 ` [PATCH 02/16] asus-wmi: Add callback for hotkey filtering Corentin Chary
2011-07-01  9:34 ` [PATCH 03/16] eeepc-wmi: Add support for T101MT Home/Express Gate key Corentin Chary
2011-07-01  9:34 ` [PATCH 04/16] asus-wmi: Enable autorepeat for hotkey input device Corentin Chary
2011-07-01 14:15   ` Matthew Garrett [this message]
2011-07-04  7:49     ` Corentin Chary
2011-07-01  9:34 ` [PATCH 05/16] asus-wmi: second part of the version starts at 16 not 8 Corentin Chary
2011-07-01  9:34 ` [PATCH 06/16] asus-wmi: add keyboard backlight support Corentin Chary
2011-07-01  9:34 ` [PATCH 07/16] asus-wmi: fix section mismatch Corentin Chary
2011-07-01  9:34 ` [PATCH 08/16] asus-wmi: set backlight type Corentin Chary
2011-07-01  9:34 ` [PATCH 09/16] asus-wmi: fix keyboard backlight detection Corentin Chary
2011-07-01  9:34 ` [PATCH 10/16] asus-wmi: add some device ids Corentin Chary
2011-07-01  9:34 ` [PATCH 11/16] asus-wmi: add thermal sensor Corentin Chary
2011-07-01  9:34 ` [PATCH 12/16] asus-wmi: check for temp1 presence Corentin Chary
2011-07-01  9:34 ` [PATCH 13/16] asus-wmi: return proper value in store_cpufv() Corentin Chary
2011-07-01  9:34 ` [PATCH 14/16] asus-wmi: add CWAP support and clarify the meaning of WAPF bits Corentin Chary
2011-07-01  9:34 ` [PATCH 15/16] asus-wmi: add gps rfkill support Corentin Chary
2011-07-01  9:34 ` [PATCH 16/16] asus-wmi: add uwb " Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110701141558.GB1363@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=corentincj@iksaif.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox