From: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ike Panhc <ike.pan@canonical.com>, joeyli <jlee@suse.com>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
mjg@redhat.com, platform-driver-x86@vger.kernel.org,
Dmitry Torokhov <dtor@mail.ru>,
Corentin Chary <corentincj@iksaif.net>,
Thomas Renninger <trenn@suse.de>,
Seth Forshee <seth.forshee@canonical.com>,
Andrey <andrey.k.p@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH resend] acer-wmi: No wifi rfkill on Lenovo machines
Date: Tue, 21 Feb 2012 03:22:54 -0600 [thread overview]
Message-ID: <20120221092254.GA26416@burratino> (raw)
In-Reply-To: <20120211191044.GA7265@burratino>
From: Ike Panhc <ike.pan@canonical.com>
Date: Fri, 3 Feb 2012 16:46:39 +0800
We have several reports which says acer-wmi is loaded on ideapads
and register rfkill for wifi which can not be unblocked.
Since ideapad-laptop also register rfkill for wifi and it works
reliably, it will be fine acer-wmi is not going to register rfkill
for wifi once VPC2004 is found.
Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
wifi rfkill capability, there are reports which says acer-wmi also
block wireless on Thinkpad E520/E420.
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
Acked-by: Lee, Chun-Yi <jlee@suse.com>
Tested-by: Andrey <andrey.k.p@gmail.com> # Ideapad Z570
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Cc: stable@vger.kernel.org
---
Hi Matthew,
Here's a patch that seems to have fallen through the cracks. Symptom
is that wifi just doesn't work on these machines until the acer-wmi
driver is unloaded. Acked by the acer-wmi maintainer (jlee). The
patch doesn't seem to be present in linux-next. Bug was present in
3.1.8, possibly on some older kernels, too.
References:
http://bugs.debian.org/655941
https://bugzilla.redhat.com/show_bug.cgi?id=674353
Anything interested people can do to move this forward?
Jonathan
drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
1 files changed, 29 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index b848277171a4..1e5290b5396d 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
return AE_OK;
}
+static int AMW0_set_cap_acpi_check_device_found;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+ u32 level, void *context, void **retval)
+{
+ AMW0_set_cap_acpi_check_device_found = 1;
+ return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+ { "VPC2004", 0},
+ { "IBM0068", 0},
+ { "LEN0068", 0},
+ { "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+ const struct acpi_device_id *id;
+
+ for (id = norfkill_ids; id->id[0]; id++)
+ acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+ NULL, NULL);
+ return AMW0_set_cap_acpi_check_device_found;
+}
+
static acpi_status AMW0_set_capabilities(void)
{
struct wmab_args args;
@@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
* work.
*/
if (wmi_has_guid(AMW0_GUID2)) {
- interface->capability |= ACER_CAP_WIRELESS;
+ if ((quirks != &quirk_unknown) ||
+ !AMW0_set_cap_acpi_check_device())
+ interface->capability |= ACER_CAP_WIRELESS;
return AE_OK;
}
--
1.7.9
next prev parent reply other threads:[~2012-02-21 9:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 6:31 [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines Lee, Chun-Yi
2012-01-09 8:01 ` Carlos Corbacho
2012-01-09 10:00 ` joeyli
2012-01-09 22:15 ` Carlos Corbacho
2012-01-11 4:26 ` joeyli
2012-01-11 16:54 ` Ike Panhc
2012-01-12 0:21 ` joeyli
2012-01-25 1:18 ` Ike Panhc
2012-01-20 2:44 ` joeyli
2012-01-25 1:29 ` Ike Panhc
2012-01-25 1:57 ` [PATCH] acer-wmi: No wifi rfkill on Lenovo machines Ike Panhc
2012-01-25 2:14 ` Ike Panhc
2012-01-26 2:53 ` joeyli
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
2012-02-03 8:55 ` Ike Panhc
2012-02-06 9:55 ` joeyli
2012-02-11 19:10 ` Jonathan Nieder
2012-02-21 9:22 ` Jonathan Nieder [this message]
2012-03-14 21:53 ` [PATCH 3.0.y] " Jonathan Nieder
2012-03-14 22:02 ` Greg KH
2012-03-14 22:17 ` Jonathan Nieder
2012-03-16 4:03 ` Ike Panhc
2012-03-16 6:11 ` joeyli
2012-03-16 17:20 ` Greg KH
2012-03-19 2:08 ` joeyli
2012-03-19 12:40 ` Andrey
2012-03-19 14:48 ` Jonathan Nieder
2012-01-24 0:04 ` [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221092254.GA26416@burratino \
--to=jrnieder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.k.p@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=corentincj@iksaif.net \
--cc=dtor@mail.ru \
--cc=ike.pan@canonical.com \
--cc=jlee@suse.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox