Re: [PATCH] [thinkpad-acpi] Add T410s and T420s LED support

[Jens Taprogge <jens.taprogge@taprogge.org>]

On Fri, Mar 23, 2012 at 07:43:55PM +0000, Matthew Garrett wrote:
> I'm a little unenthusiastic about just pulling this in without working 
> out how userspace is going to consume it. It's a problem we may hit on 
> other devices as well, so we potentially need some sort of consistent 
> naming to indicate that it's a built-in mute LED.

Would a name like "laptop_mute_mic" be more descriptive?  Please note
that with the patch the LED only exposed if
CONFIG_THINKPAD_ACPI_UNSAFE_LEDS is set.  (And so are other like for
example the battery LEDs.)

If possible, I think it would be good to generally handle the LED in
kernel space.  Otherwise, the risk of the LED getting out of sync with
the actually muting is just to big.  I am not sure how that could be
achieved though.  Basically ALSA would have to expose some kind of hook
that thinkpad_acpi (or other users) could connect to.

Best Regards
-Jens