Re: [PATCH] toshiba_acpi: Add SCI operations and adapt Illumination code

[Seth Forshee <seth.forshee@canonical.com>]

On Thu, May 03, 2012 at 02:46:56PM -0600, Azael Avalos wrote:
> SCI stands for Software Configuration Interface and
> it is supposed to be present on all Toshiba models.
> 
> Illumination code is now adapted to use SCI calls and
> is not registered unless the SCI is present.
> 
> Signed-off-by: Azael <coproscefalo@gmail.com>

One tiny little style problem, otherwise this looks okay to me.

Also worth noting is that I tested an earlier but nearly identical
version of this patch on an NB505 (no illumination support) and saw no
adverse effects.

> @@ -1099,6 +1127,14 @@ static int __devinit toshiba_acpi_add(struct
> acpi_device *acpi_dev)
>  	dev->method_hci = hci_method;
>  	acpi_dev->driver_data = dev;
> 
> +	/* Open Toshiba SCI, if present */
> +	ret = sci_open(dev);
> +	if (ret == 0) {
> +		pr_info("Toshiba SCI could not be opened.\n");
> +		dev->sci_opened = 0;
> +	} else
> +		dev->sci_opened = 1;
> +

Kernel style dictates that when one branch of a conditional has braces,
all other branches should also have braces.