Re: [PATCH] thinkpad_acpi: added BIOS mute interfaces for volume

[Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>]

On Sun, 08 Jul 2012, Alex Hung wrote:
> Will it be a better idea to disable hardware mute? The hardware mute
> will still send a scancode to mute the volue when thinkpad-acpi is
> loaded, though the led will still not work. More specifically, a
> patch that only calls with hoteky_set_mute_support(1) that works as
> below:

I don't mind adding that as a module paramenter and a sysfs control, but
make it a multi-value integer as follows:

-1:  auto   (right now that means don't touch it.  We can change its meaning
             after some testing)
0 : disable hw mute
1 : enable  hw mute

All other values must return -EINVAL (reserved, to be implemented later).

On thinkpads where no SHDA functionality is supported, do not publish the
sysfs node.  I can test in the T43 if it is EC-supported but not published
in the DSDT, please send me the relevant acpidump of a thinkpad that
implements SHDA, please.

Relevant documentation patch for Documentation/laptops/thinkpad-acpi.txt is
required for an Ack, of course :-)

> This can solve the problems that unmute from desktop will not unmute
> the hardware mute until someone including myself works out a more
> comprehensive solution.

Agreed.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/