From: Seth Forshee <seth.forshee@canonical.com>
To: Bernhard Froemel <froemel@vmars.tuwien.ac.at>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
Andreas Heider <andreas@meetr.de>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] apple-gmux: Add support for message box interface (as found in MBP10,1/Retina MacBook Pro)
Date: Mon, 13 Aug 2012 14:15:37 -0500 [thread overview]
Message-ID: <20120813191537.GG24088@thinkpad-t410> (raw)
In-Reply-To: <50294E9D.8050905@vmars.tuwien.ac.at>
On Mon, Aug 13, 2012 at 08:59:41PM +0200, Bernhard Froemel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/13/2012 08:17 PM, Seth Forshee wrote:
> > It was discussed briefly on irc.
> >
> > http://irclogs.ubuntu.com/2012/08/09/%23ubuntu-kernel.txt
> >
> Yes, it's very similar. Don't want to start any wars here ;) but:
> >>> but I think his implementation looked cleaner
> I only occasionally write kernel code, but can't there be any
> concurrency issues during reads/writes of internal gmux registers (I
> used a semaphore to prevent that)? Especially if vga_switcheroo also
> taps in?
There aren't concurrency issues right now since only backlight is
supported, and the backlight class driver serializes callbacks into the
driver with a mutex. But when switcheroo support is added some
concurrency protection is probably necessary. A mutex should be used
rather than a semaphore however.
Seth
prev parent reply other threads:[~2012-08-13 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 9:42 [PATCH] apple-gmux: Add support for message box interface (as found in MBP10,1/Retina MacBook Pro) Bernhard Froemel
2012-08-13 17:09 ` Seth Forshee
2012-08-13 18:01 ` Bernhard Froemel
2012-08-13 18:13 ` Greg KH
2012-08-13 18:21 ` Seth Forshee
2012-08-13 18:28 ` Seth Forshee
2012-08-13 18:36 ` Bernhard Froemel
2012-08-13 18:17 ` Seth Forshee
2012-08-13 18:59 ` Bernhard Froemel
2012-08-13 19:15 ` Seth Forshee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813191537.GG24088@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=andreas@meetr.de \
--cc=froemel@vmars.tuwien.ac.at \
--cc=gregkh@linuxfoundation.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox